-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add 'sviewgui' to list of thirdparty packages #15864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please scale down the PNG. It is huge in dimensions 5349 x 4234px and in memory size (1.22 MB).
- Please scale your image down to a width of 900px (The width of the docs body is just a little more than 900px. Larger images will just be scaled down by the browser).
- After that, run the resulting png through a compressor like https://tinypng.com/. We don't want to unnecessarily bloat the repo and serve larger images than necessary to the user.
I modified the size of PNG and re-uploaded. |
Thank you for the PR! This looks like a great tool! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I find the font size of the code part in the image a bit too large compared to the screenshots and the regular font size of the page. It would be nice to make that a bit smaller, but wouldn't insist.
doc/thirdpartypackages/index.rst
Outdated
sviewgui | ||
======== | ||
|
||
`sviewgui <https://pypi.org/project/sviewgui/>`_ is a handy PyQt-based GUI for data visualisation. This GUI is based on the matplotlib and you can visualize your csv file in various ways by only one simple method 'buildGUI()'. Here are the main features; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Try to be more to the point in the description. Adjectives like "handy" and "readily" are an opinion and do not add to the information.
- You can use markup to structure the the text, e.g. bullet points.
- Wrap the lines at 79 chars, as that's the convention used elsewhere in the file.
I'd recommend something like this:
`sviewgui <https://pypi.org/project/sviewgui/>`_ is a PyQt-based GUI for
visualisation of data from csv files or `pandas.DataFrames`. Main features:
- Scatter, line, density, histgram, and box plot types
- Settings for the marker size, line width, number of bins of histgram,
color map (from cmocean)
- Save figure as editable PDF
- Code of the plotted graph is available so that it can be reused and modified
outside of sviewgui
Co-Authored-By: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Thank you for your suggestions. |
Compressed using TinyPNG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of running the example PNG though TinyPNG to compress it from 180kb to 50kb and pushed to your branch.
This is good to go after CI has passed and the commits need to be squashed to remove the initially large PNG (Squashing can be done as part of the merge via github UI),
Thanks for your contribution! Maybe see you back some time. |
…864-on-v3.2.x Backport PR #15864 on branch v3.2.x ([Add the info of 'sviewgui' in thirdparty package])
Looks like you forgot to squashmerge :/ |
PR Summary
PR Checklist