8000 Add 'sviewgui' to list of thirdparty packages by SojiroFukuda · Pull Request #15864 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Add 'sviewgui' to list of thirdparty packages #15864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 31, 2019

Conversation

SojiroFukuda
Copy link
Contributor
@SojiroFukuda SojiroFukuda commented Dec 7, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please scale down the PNG. It is huge in dimensions 5349 x 4234px and in memory size (1.22 MB).

  • Please scale your image down to a width of 900px (The width of the docs body is just a little more than 900px. Larger images will just be scaled down by the browser).
  • After that, run the resulting png through a compressor like https://tinypng.com/. We don't want to unnecessarily bloat the repo and serve larger images than necessary to the user.

@SojiroFukuda
Copy link
Contributor Author

I modified the size of PNG and re-uploaded.
And I fixed the text.

@story645
Copy link
Member

Thank you for the PR! This looks like a great tool! 😄

Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I find the font size of the code part in the image a bit too large compared to the screenshots and the regular font size of the page. It would be nice to make that a bit smaller, but wouldn't insist.

sviewgui
========

`sviewgui <https://pypi.org/project/sviewgui/>`_ is a handy PyQt-based GUI for data visualisation. This GUI is based on the matplotlib and you can visualize your csv file in various ways by only one simple method 'buildGUI()'. Here are the main features;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Try to be more to the point in the description. Adjectives like "handy" and "readily" are an opinion and do not add to the information.
  • You can use markup to structure the the text, e.g. bullet points.
  • Wrap the lines at 79 chars, as that's the convention used elsewhere in the file.

I'd recommend something like this:

`sviewgui <https://pypi.org/project/sviewgui/>`_ is a PyQt-based GUI for
visualisation of data from csv files or `pandas.DataFrames`. Main features:

- Scatter, line, density, histgram, and box plot types
- Settings for the marker size, line width, number of bins of histgram,
  color map (from cmocean)
- Save figure as editable PDF
- Code of the plotted graph is available so that it can be reused and modified
  outside of sviewgui

SojiroFukuda and others added 3 commits December 30, 2019 16:35
Co-Authored-By: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
@SojiroFukuda
Copy link
Contributor Author

Thank you for your suggestions.
I changed the picture and text.

Compressed using TinyPNG
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of running the example PNG though TinyPNG to compress it from 180kb to 50kb and pushed to your branch.

This is good to go after CI has passed and the commits need to be squashed to remove the initially large PNG (Squashing can be done as part of the merge via github UI),

@timhoffm timhoffm dismissed their stale review December 31, 2019 15:16

Comments handled.

@timhoffm timhoffm added this to the v3.2.0 milestone Dec 31, 2019
@timhoffm timhoffm merged commit 3261ed2 into matplotlib:master Dec 31, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 31, 2019
@timhoffm timhoffm changed the title [Add the info of 'sviewgui' in thirdparty package] Add 'sviewgui' to list of thirdparty packages Dec 31, 2019
@timhoffm
Copy link
Member

Thanks for your contribution! Maybe see you back some time.

QuLogic added a commit that referenced this pull request Dec 31, 2019
…864-on-v3.2.x

Backport PR #15864 on branch v3.2.x ([Add the info of 'sviewgui' in thirdparty package])
@anntzer
Copy link
Contributor
anntzer commented Dec 31, 2019

Looks like you forgot to squashmerge :/
Edit: ah, no, sorry, it's just the github UI which is confusing and still shows the separate commits...

@anntzer anntzer mentioned this pull request Jan 2, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0