8000 Remove some dead branches from texmanager code. by anntzer · Pull Request #15847 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove some dead branches from texmanager code. #15847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

Remove some dead branches from texmanager code. #15847

merged 1 commit into from
Jan 9, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Dec 6, 2019 •
edited
Loading
  1. get_cachedir() never returns None (244e8d8/Don't pretend to support Google App Engine. #8939).
  2. rcParams["font.family"] is always a list of str(s), not a single str
    (its rc validator in rcsetup is validate_stringlist).

--
edit: turns out a few more docstrings need to be cleaned :)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the texman branch 2 times, most recently from cd37235 to ac87adb Compare December 6, 2019 17:53
tacaswell
tacaswell reviewed Dec 6, 2019
View reviewed changes
@anntzer anntzer force-pushed the texman branch 2 times, most recently from b09fb5f to b63a0e2 Compare December 7, 2019 12:40
@tacaswell tacaswell added this to the v3.3.0 milestone Dec 8, 2019
@anntzer
Remove some dead branches from texmanager code.
3e21d60 
1) get_cachedir() never returns None (244e8d8).
2) rcParams["font.family"] is always a list of str(s), not a single str
   (its rc validator in rcsetup is validate_stringlist).
@tacaswell tacaswell merged commit e05681f into matplotlib:master Jan 9, 2020
@anntzer anntzer deleted the texman branch January 9, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Maintenance topic: text/usetex
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @tacaswell @timhoffm @QuLogic
0