Modernize FAQ entry for plt.show(). #15751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- show() can now be called multiple times (admittedly, I don't know for the OSX backend, all others do work fine). - Move all references to pre-1.0 behavior together at the end. - One can actually call savefig() after interactively closing a figure; the only thing is that one would need to call fig.savefig() rather than plt.savefig() as pyplot loses track of the figure once it is closed. So slightly reword the corresponding admonition (no need to go into the details there).
timhoffm
approved these changes
Nov 22, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 22, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 22, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Nov 22, 2019
timhoffm
added a commit
that referenced
this pull request
Nov 22, 2019
…751-on-v3.1.1-doc Backport PR #15751 on branch v3.1.1-doc (Modernize FAQ entry for plt.show().)
timhoffm
added a commit
that referenced
this pull request
Nov 22, 2019
…751-on-v3.1.x Backport PR #15751 on branch v3.1.x (Modernize FAQ entry for plt.show().)
timhoffm
added a commit
that referenced
this pull request
Nov 23, 2019
…751-on-v3.2.x Backport PR #15751 on branch v3.2.x (Modernize FAQ entry for plt.show().)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the OSX backend, all others do work fine).
the only thing is that one would need to call fig.savefig() rather
than plt.savefig() as pyplot loses track of the figure once it is
closed. So slightly reword the corresponding admonition (no need to
go into the details there).
PR Summary
PR Checklist