8000 Tried to solve Issue #15650: Print URL when webbrowser.open Fails by manan2501 · Pull Request #15701 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Tried to solve Issue #15650: Print URL when webbrowser.open Fails #15701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2019
Merged

Tried to solve Issue #15650: Print URL when webbrowser.open Fails #15701

merged 2 commits into from
Nov 17, 2019

Conversation

manan2501
Copy link
Contributor
@manan2501 manan2501 commented Nov 16, 2019 •
edited by timhoffm
Loading

PR Summary

Currently, the URL is shown only when rcParams['webagg.open_in_browser'] is False.
I have made changes so that the URL will be printed when webbrowser.open fails.

Closes #15650.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic
QuLogic reviewed Nov 16, 2019
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, please try to give commits more descriptive messages, so that one does not need to try to figure out what #15650 means.

@manan2501 @QuLogic
Update lib/matplotlib/backends/backend_webagg.py
672f5ca 
Co-Authored-By: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@manan2501
Copy link
Contributor Author

In the future, please try to give commits more descriptive messages, so that one does not need to try to figure out what #15650 means.

Pardon me for that(This was my first PR to such a huge project)

@manan2501 manan2501 changed the title Tried to solve Issue #15650 Tried to solve Issue #15650: Print URL when webbrowser.open Fails Nov 16, 2019
@QuLogic
Copy link
Member
QuLogic commented Nov 16, 2019

I'm having a hard time finding the return value for webbrowser.open, @anntzer. Is this some undocumented result?

@anntzer
Copy link
Contributor
anntzer commented Nov 16, 2019

It's not documented AFAICT, you can just infer it from the source code (https://github.com/python/cpython/blob/3.8/Lib/webbrowser.py#L71).

@manan2501 manan2501 requested a review from QuLogic November 17, 2019 12:43
@dstansby dstansby added this to the v3.3.0 milestone Nov 17, 2019
dstansby
dstansby approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉

@dstansby dstansby merged commit 690fd71 into matplotlib:master Nov 17, 2019
@manan2501 manan2501 deleted the issue-15650 branch November 17, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@dstansby dstansby dstansby approved these changes

@QuLogic QuLogic Awaiting requested review from QuLogic

Assignees
No one assigned
Labels
GUI: webagg
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

URL is not shown when webagg failed to open the browser.
5 participants
@manan2501 @QuLogic @anntzer @timhoffm @dstansby
0