-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Fix test suite compat with ghostscript 9.50. #15556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghostscript 9.50 defaults to -dSAFER (https://www.ghostscript.com/doc/9.50/Use.htm#Safer) which prevents the converter from writing png files resulting from conversion from pdf. Fix that by passing -dNOSAFER, which was the default on older ghostscripts (and backcompatible). Needed to pass the test suite on e.g. an up-to-date Arch Linux.
timhoffm
approved these changes
Oct 29, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 29, 2019
dstansby
added a commit
that referenced
this pull request
Oct 29, 2019
…556-on-v3.2.x Backport PR #15556 on branch v3.2.x (Fix test suite compat with ghostscript 9.50.)
@meeseeksdev backport to v3.1.x |
1 similar comment
@meeseeksdev backport to v3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jan 13, 2020
timhoffm
added a commit
that referenced
this pull request
Jan 14, 2020
…556-on-v3.1.x Backport PR #15556 on branch v3.1.x (Fix test suite compat with ghostscript 9.50.)
gaomy3832
added a commit
to gaomy3832/easypyplot
that referenced
this pull request
Jan 1, 2022
- Use strings for python-version; actions/setup-python#160. - Add missing dependency ghostscript. - Use standard way to set env vars; https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#setting-an-environment-variable. - Fix an issue with ghostscript 9.50; matplotlib/matplotlib#15556. - Fix an issue with matplotlib 1.4; https://stackoverflow.com/a/27085321. - Add comments.
gaomy3832
added a commit
to gaomy3832/easypyplot
that referenced
this pull request
Jan 4, 2022
- Use strings for python-version; actions/setup-python#160. - Add missing dependency ghostscript. - Use standard way to set env vars; https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#setting-an-environment-variable. - Fix an issue with ghostscript 9.50; matplotlib/matplotlib#15556. - Fix an issue with matplotlib 1.4; https://stackoverflow.com/a/27085321. - Add comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghostscript 9.50 defaults to -dSAFER
(https://www.ghostscript.com/doc/9.50/Use.htm#Safer)
which prevents the converter from writing png files resulting from
conversion from pdf. Fix that by passing -dNOSAFER, which was the
default on older ghostscripts (and backcompatible).
Needed to pass the test suite on e.g. an up-to-date Arch Linux.
PR Summary
PR Checklist