8000 Fix test suite compat with ghostscript 9.50. by anntzer · Pull Request #15556 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Fix test suite compat with ghostscript 9.50. #15556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Oct 28, 2019

ghostscript 9.50 defaults to -dSAFER
(https://www.ghostscript.com/doc/9.50/Use.htm#Safer)
which prevents the converter from writing png files resulting from
conversion from pdf. Fix that by passing -dNOSAFER, which was the
default on older ghostscripts (and backcompatible).

Needed to pass the test suite on e.g. an up-to-date Arch Linux.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

ghostscript 9.50 defaults to -dSAFER
(https://www.ghostscript.com/doc/9.50/Use.htm#Safer)
which prevents the converter from writing png files resulting from
conversion from pdf.  Fix that by passing -dNOSAFER, which was the
default on older ghostscripts (and backcompatible).

Needed to pass the test suite on e.g. an up-to-date Arch Linux.
@tacaswell tacaswell modified the milestones: v3.2.0, v3.1.2 Oct 29, 2019
@tacaswell tacaswell merged commit 062c517 into matplotlib:master Oct 29, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Oct 29, 2019
@anntzer anntzer deleted the gs950 branch October 29, 2019 07:30
dstansby added a commit that referenced this pull request Oct 29, 2019
…556-on-v3.2.x

Backport PR #15556 on branch v3.2.x (Fix test suite compat with ghostscript 9.50.)
@tacaswell
Copy link
Member
tacaswell commented Jan 13, 2020

@meeseeksdev backport to v3.1.x

1 similar comment
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 13, 2020
timhoffm added a commit that referenced this pull request Jan 14, 2020
…556-on-v3.1.x

Backport PR #15556 on branch v3.1.x (Fix test suite compat with ghostscript 9.50.)
gaomy3832 added a commit to gaomy3832/easypyplot that referenced this pull request Jan 1, 2022
- Use strings for python-version;
actions/setup-python#160.

- Add missing dependency ghostscript.

- Use standard way to set env vars;
https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#setting-an-environment-variable.

- Fix an issue with ghostscript 9.50;
matplotlib/matplotlib#15556.

- Fix an issue with matplotlib 1.4;
https://stackoverflow.com/a/27085321.

- Add comments.
gaomy3832 added a commit to gaomy3832/easypyplot that referenced this pull request Jan 4, 2022
- Use strings for python-version;
actions/setup-python#160.

- Add missing dependency ghostscript.

- Use standard way to set env vars;
https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#setting-an-environment-variable.

- Fix an issue with ghostscript 9.50;
matplotlib/matplotlib#15556.

- Fix an issue with matplotlib 1.4;
https://stackoverflow.com/a/27085321.

- Add comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0