8000 Separate plots using #### in make_room_for_ylabel_using_axesgrid.py by ardieorden · Pull Request #15513 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Separate plots using #### in make_room_for_ylabel_using_axesgrid.py #15513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2019
Merged

Separate plots using #### in make_room_for_ylabel_using_axesgrid.py #15513

merged 3 commits into from
Dec 2, 2019

Conversation

ardieorden
Copy link
Contributor

PR Summary

Separate plots using ######### lines for Sphinx-gallery to render plots in sections.
Part of #8922.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Oct 26, 2019
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that each example gets its own code block you can remove the functions and write the commands as top-level code. This is shorter and easier to read.

@ardieorden
Copy link
Contributor Author
ardieorden commented Nov 21, 2019 •
edited
Loading

Thanks for the feedback and apologies for the late response! I removed the functions and wrote them as top-level code instead and I also removed the figure numbers for each code block. Let me know if you'd like to see other changes!

@ardieorden ardieorden requested a review from timhoffm November 21, 2019 14:05
QuLogic
QuLogic reviewed Nov 22, 2019
View reviewed changes
@ardieorden ardieorden requested a review from QuLogic November 22, 2019 23:06
@ardieorden
Copy link
Contributor Author

Thanks for the code review @QuLogic ! I committed the changes for importing matplotlib and assigning the fig variable and I squashed it to the previous commit for cleanliness.

Let me know if you'd like to see other changes!

timhoffm
timhoffm reviewed Dec 2, 2019
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to matplotlib.pyplot as plt. Should be above the other imports.

@ardieorden
Copy link
Contributor Author

Thanks for the comment @timhoffm ! I just added in the import matplotlib.pyplot as plt line above all the other imports and I removed the commented out line. Let me know if you'd like to request for more changes!

@ardieorden ardieorden requested a review from timhoffm December 2, 2019 01:47
@timhoffm timhoffm added this to the v3.2.1 milestone Dec 2, 2019
@timhoffm timhoffm merged commit 0f88d8c into matplotlib:master Dec 2, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 2, 2019
@timhoffm
Backport PR matplotlib#15513: Separate plots using #### in make_room_…
d07211d 
…for_ylabel_using_axesgrid.py
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 2, 2019
Merged
@timhoffm
Copy link
Member
timhoffm commented Dec 2, 2019

Thanks, and congratulations on your first contribution to Matplotlib! Hope to see you back some time.

timhoffm added a commit that referenced this pull request Dec 2, 2019
@timhoffm
Merge pull request #15808 from meeseeksmachine/auto-backport-of-pr-15…
6348c18 
…513-on-v3.2.x

Backport PR #15513 on branch v3.2.x (Separate plots using #### in make_room_for_ylabel_using_axesgrid.py)
@QuLogic QuLogic modified the milestones: v3.2.1, v3.2.0 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

@QuLogic QuLogic Awaiting requested review from QuLogic

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ardieorden @timhoffm @QuLogic @dstansby @tm-ardie-orden
0