Replace _prod_vectorized by @-multiplication. #15374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tacaswell
reviewed
Oct 4, 2019
lib/matplotlib/tri/triinterpolate.py
Outdated
| dV = dV @ _extract_submatrices( | ||
| self.rotate_dV, subtri, block_size=2, axis=0) | ||
|
|
||
| prod = (self.M @ dV |
There was a problem hiding this comment.
Do we pay a performance hit for temporaries here?
There was a problem hiding this comment.
Given that it‘s not in a tight loop, it can‘t be too bad. Anyway it‘s the same as before.
There was a problem hiding this comment.
actually I initially thought that the temporaries would be the same but that's not the case; even if I doubt this really matters performance-wise I restored the old form.
@-multiplication has the exact same broadcasting behavior as _prod_vectorized (`...ij,...jk->...ik` in einsum notation).
QuLogic
approved these changes
Sep 9, 2020
timhoffm
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@-multiplication has the exact same broadcasting behavior as
_prod_vectorized (
...ij,...jk->...ikin einsum notation).(It's not the same as for
np.dot.)PR Summary
PR Checklist