8000 Always attach a manager attribute (possibly None) on canvas. by anntzer · Pull Request #15340 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Always attach a manager attribute (possibly None) on canvas. #15340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2019
Merged

Always attach a manager attribute (possibly None) on canvas. #15340

merged 1 commit into from
Sep 25, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 25, 2019

This avoids the confusion in the earlier implementation of Figure.show,
which checked separately for whether the attribute existed and whether
it is None, and (wrongly, I believe) handled the two cases differently.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Always attach a manager attribute (possibly None) on canvas.
3ccc17b 
This avoids the confusion in the earlier implementation of Figure.show,
which checked separately for whether the attribute existed and whether
it is None, and (wrongly, I believe) handled the two cases differently.
@timhoffm timhoffm added this to the v3.3.0 milestone Sep 25, 2019
@tacaswell tacaswell merged commit f491493 into matplotlib:master Sep 25, 2019
@anntzer anntzer deleted the manager branch September 25, 2019 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @tacaswell
0