8000 Fix typo/bug from 18cecf7 by timhoffm · Pull Request #15296 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Fix typo/bug from 18cecf7 #15296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Fix typo/bug from 18cecf7 #15296

merged 1 commit into from
Sep 18, 2019

Conversation

timhoffm
Copy link
Member

PR Summary

See #15271 (review)

I'm sorry, this slipped in with a force push in some late stage.

@timhoffm timhoffm added this to the v3.1.2 milestone Sep 18, 2019
@timhoffm timhoffm added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 18, 2019
@jklymak jklymak merged commit 9b41113 into matplotlib:master Sep 18, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 18, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Sep 18, 2019
@QuLogic
Copy link
Member
QuLogic commented Sep 18, 2019

No worries, I should have seen it when merging too.

@tacaswell
Copy link
Member

To quote Michael Droettboom quoting one of his early bosses "If you don't break the build, you are not writing enough code" ;). Mistakes happen 🤷‍♀️ thanks for finding it and fixing it quickly!

tacaswell added a commit that referenced this pull request Sep 18, 2019
…296-on-v3.1.x

Backport PR #15296 on branch v3.1.x (Fix typo/bug from 18cecf7)
@timhoffm timhoffm deleted the fix-typo branch September 18, 2019 23:15
tacaswell added a commit that referenced this pull request Sep 24, 2019
…296-on-v3.2.x

Backport PR #15296 on branch v3.2.x (Fix typo/bug from 18cecf7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0