10000 Colorbar cleanup. by anntzer · Pull Request #15282 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Colorbar cleanup. #15282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

Colorbar cleanup. #15282

merged 1 commit into from
Sep 18, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 17, 2019

PR Summary

mostly removing explicit rst roles from docs; tiny refactorings as well.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak
jklymak approved these changes Sep 17, 2019
View reviewed changes
lib/matplotlib/colorbar.py
@@ -644,8 +634,7 @@ def update_ticks(self):
locator, formatter = self._get_ticker_locator_formatter()
long_axis = ax.yaxis if self.orientation == 'vertical' else ax.xaxis
if self._use_auto_colorbar_locator():
_log.debug('Using auto colorbar locator on colorbar')
_log.debug('locator: %r', locator)
_log.debug('Using auto colorbar locator %r on colorbar', locator)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put this in as a debugging step at some point I think. Not sure what our policy is vis-a-vis lots of debugs, so feel free to remove it if its too crufty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think leaving one log line is fine.

@timhoffm timhoffm added this to the v3.3.0 milestone Sep 18, 2019
@timhoffm timhoffm merged commit 4b27b46 into matplotlib:master Sep 18, 2019
@anntzer anntzer deleted the colorbar branch September 18, 2019 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @timhoffm
0