8000 In findfont(fallback_to_default=False), throw if default font is missing by anntzer · Pull Request #15249 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

In findfont(fallback_to_default=False), throw if default font is missing #15249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

In findfont(fallback_to_default=False), throw if default font is missing #15249

merged 1 commit into from
Sep 12, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 11, 2019

... instead of entering an infinite loop of findfont -> defaultFont ->
findfont.

A bit of a pain to test (one needs to delete dejavusans both from the
mpl source tree and from the system font folder)...

This should only affect people who delete the default fonts anyways (or
call with fallback_to_default=False), so I'll skip the API change note.

Closes https://gitter.im/matplotlib/matplotlib?at=5d78acdd767de913fcbda27c.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
In findfont(fallback_to_default=False), throw if default font is miss…
8a543b5 
…ing.

... instead of entering an infinite loop of findfont -> defaultFont ->
findfont.

A bit of a pain to test (one needs to delete dejavusans both from the
mpl source tree and from the system font folder)...

This should only affect people who delete the default fonts anyways (or
call with fallback_to_default=False), so I'll skip the API change note.
@anntzer anntzer force-pushed the fallback_to_default branch from a398ef2 to 8a543b5 Compare September 11, 2019 20:18
@timhoffm
Copy link
Member

@QuLogic is there a reason that you approve but don’t merge?

@QuLogic
Copy link
Member
QuLogic commented Sep 12, 2019

The build needed restarting.

@QuLogic QuLogic added this to the v3.3.0 milestone Sep 12, 2019
@QuLogic QuLogic merged commit 770d59d into matplotlib:master Sep 12, 2019
@anntzer anntzer deleted the fallback_to_default branch September 12, 2019 22:03
@timhoffm
Copy link
Member
timhoffm commented Sep 12, 2019 •
edited
Loading

Since v3.2.0 is not yet branched would this still go in 3.2.0? what is the branch policy? Do we just branch from master at some point or do we branch from some previous commit so that current master is already targeting 3.3.0?

@QuLogic
Copy link
Member
QuLogic commented Sep 12, 2019

3.2.0 was branched https://github.com/matplotlib/matplotlib/tree/v3.2.x It was announced yesterday.

@timhoffm
Copy link
Member

👍 Never mind, maybe I've just checked an old brower tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: text/fonts
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @QuLogic
0