8000 Fix incorrect calls to warn_deprecated. by anntzer · Pull Request #15245 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix incorrect calls to warn_deprecated. #15245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2019
Merged

Fix incorrect calls to warn_deprecated. #15245

merged 1 commit into from
Sep 11, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 11, 2019
  1. message is keyword-only.
  2. it's %(since)s, not %(version)s.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Fix incorrect calls to warn_deprecated.
df3834e 
1) `message` is keyword-only.
2) it's `%(since)s`, not `%(version)s`.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 11, 2019
@anntzer anntzer added this to the v3.2.0 milestone Sep 11, 2019
@anntzer anntzer mentioned this pull request Sep 11, 2019
Closed
6 tasks
@jklymak jklymak merged commit 34ac5b5 into matplotlib:master Sep 11, 2019
@anntzer anntzer deleted the deprecations branch September 11, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @timhoffm @jklymak
0