Doc: Remove hard-documented rcParams defaults #15230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImportanceOfBeingErnest
approved these changes
Sep 9, 2019
QuLogic
reviewed
Sep 9, 2019
| @@ -5,7 +5,7 @@ | |||
|
|
|||
| By default, tick labels at negative values are rendered using a `Unicode | |||
| minus`__ (U+2212) rather than an ASCII hyphen (U+002D). This can be controlled | |||
| by setting :rc:`axes.unicode_minus` (which defaults to True). | |||
| by setting :rc:`axes.unicode_minus`. | |||
There was a problem hiding this comment.
We should re-write this sentence somewhat. With the default there, it seems like it's saying you should set it to the default. But the sentence is only trying to say set it to anything (manually.)
This was referenced Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
#15115 introduced automatic documentation of rcParams defaults. Therefore, we should remove hard-coded defaults, which are now just duplicates such as
or were even incorrect: