8000 Explicitly list allowed "unused" imports, remove the rest. by anntzer · Pull Request #15210 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Explicitly list allowed "unused" imports, remove the rest. #15210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

Explicitly list allowed "unused" imports, remove the rest. #15210

merged 1 commit into from
Oct 1, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Sep 7, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak
Copy link
Member
jklymak commented Oct 1, 2019

So why do those files keep their "unused" imports?

@anntzer
Copy link
Contributor Author
anntzer commented Oct 1, 2019

Because they are effectively public API (you can import TextPath from matplotlib.text, even though you should really import it from matplotlib.textpath; or, for the constants in matplotlib._image, matplotlib.image is the public place from which you can import them).

@jklymak jklymak merged commit ee26217 into matplotlib:master Oct 1, 2019
@jklymak jklymak added this to the v3.3.0 milestone Oct 1, 2019
@anntzer anntzer deleted the unusedimports branch October 1, 2019 17:10
@anntzer anntzer mentioned this pull request Oct 1, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jklymak @QuLogic
0