8000 Cleanup legend() docstring. by anntzer · Pull Request #15112 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Cleanup legend() docstring. #15112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2019
Merged

Cleanup legend() docstring. #15112

merged 1 commit into from
Aug 24, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Aug 23, 2019

I think "means using" reads better than "will take the value from", but
am happy to hear other wordings proposals too
(probably should be uniformized throughout the library...).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@ImportanceOfBeingErnest
Copy link
Member

Slightly OT, but this reminds me that I'm always bothered by the documentation not stating the default value (meaning you have to click on the link to the rcparams and search for the value in the long list of (lexographically unsorted) values for the one you're interested in). This just brought me to the idea of #15115.

@anntzer
Cleanup legend() docstring.
a8b6d4f 
I think "means using" reads better than "will take the value from", but
am happy to hear other wordings proposals too.
@ImportanceOfBeingErnest ImportanceOfBeingErnest added this to the v3.2.0 milestone Aug 23, 2019
@tacaswell tacaswell merged commit d601e03 into matplotlib:master Aug 24, 2019
@tacaswell
Copy link
Member

Thanks!

@anntzer anntzer deleted the legenddoc branch August 24, 2019 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @ImportanceOfBeingErnest @tacaswell
0