Use fix_minus in format_data_short. #14949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Aug 7, 2019
|
This is missing a unit test. |
6a76383 to
93e0084
Compare
|
Some of this is already tested by TestEngFormatter.test_params. There are no tests specifically for ScalarFormatter.format_data_short, but this PR doesn't change that situation. |
|
You should test the behavior that has changed in this PR. Else, there is no way to check that we will not revert to the old behavior. |
See changelog. AFAICS, all GUI toolkits (at least qt5/gtk3/wx/tk) display the unicode minus properly. Moving the implementation of the replacement to the base Formatter class is because it is otherwise confusing as to whether `self.fix_minus` does the replacement or not -- one needs to check whether the current class overrides the do-nothing fix_minus. Instead, one can just have a base-class implementation that performs the replacement, and not call `self.fix_minus` if the replacement is not desired. For example, LogFormatter.fix_minus used to do nothing; there are tests that check that. Just don't call fix_minus instead.
|
Sure. |
jklymak
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog. AFAICS, all GUI toolkits (at least qt5/gtk3/wx/tk)
display the unicode minus properly.
before:
after:
(compare the minus in "x=-...")
Moving the implementation of the replacement to the base Formatter class
is because it is otherwise confusing as to whether
self.fix_minusdoes the replacement or not -- one needs to check whether the current
class overrides the do-nothing fix_minus. Instead, one can just have a
base-class implementation that performs the replacement, and not call
self.fix_minusif the replacement is not desired.For example, LogFormatter.fix_minus used to do nothing; there are tests
that check that. Just don't call fix_minus instead.
PR Summary
PR Checklist