8000 Reuse TexManager implementation in convert_psfrags. by anntzer · Pull Request #14833 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Reuse TexManager implementation in convert_psfrags. #14833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 24, 2019
Merged

Reuse TexManager implementation in convert_psfrags. #14833

merged 1 commit into from
Aug 24, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jul 17, 2019

This allows convert_psfrags to also benefit from improvements to
texmanager, such as the recent addition of support for unicode minus (#14567).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the convert_psfrags branch 2 times, most recently from eb8dac9 to d290e56 Compare July 17, 2019 20:03
@QuLogic
Copy link
Member
QuLogic commented Jul 18, 2019

Huh? There's no coverage check?

@anntzer
Copy link
Contributor Author
anntzer commented Jul 18, 2019 •
edited
Loading

what do you mean? https://codecov.io/gh/matplotlib/matplotlib/compare/2d56d42565308e2afcfca152f2df2955439ec898...d290e569cd34af9231ffb71d6ea0a1cc78104e7d/src/lib/matplotlib/backends/backend_ps.py seems happy.
Manually adding prints there and running test_backend_ps also shows that this is being run.

Edit:
Additionally made dvips output its result to a temporary directory, rather than to tmpfile + ".ps", which very technically could already exist; this also removes the need for manual cleanup.

@anntzer anntzer force-pushed the convert_psfrags branch 2 times, most recently from 3403aaa to c64ebf6 Compare July 18, 2019 08:39
@anntzer
Reuse TexManager implementation in convert_psfrags.
200094d 
This allows convert_psfrags to also benefit from improvements to
texmanager, such as the recent addition of support for unicode minus.
@QuLogic
Copy link
Member
QuLogic commented Jul 19, 2019

I mean it didn't show up in the checks before.

@tacaswell tacaswell added this to the v3.2.0 milestone Aug 12, 2019
@tacaswell tacaswell merged commit 1f6f05b into matplotlib:master Aug 24, 2019
@anntzer anntzer deleted the convert_psfrags branch August 24, 2019 20:56
@QuLogic QuLogic mentioned this pull request Apr 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
backend: ps
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @tacaswell
0