8000 Inset orientation by timhoffm · Pull Request #14686 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Inset orientation #14686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2019
Merged

Inset orientation #14686

merged 1 commit into from
Jul 16, 2019

Conversation

timhoffm
Copy link
Member
@timhoffm timhoffm commented Jul 3, 2019

PR Summary

Fixes #14670.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant

@timhoffm timhoffm force-pushed the inset-orientation branch from 8f96f6d to d60459d Compare July 3, 2019 22:35
jklymak
jklymak approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member
@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@clbarnes
Copy link
Contributor
clbarnes commented Jul 6, 2019

Thanks for jumping onto this quickly! I was going to get round to it...

@dstansby dstansby added this to the v3.2.0 milestone Jul 15, 2019
dstansby
dstansby approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member
@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just needs a rebase

@timhoffm timhoffm force-pushed the inset-orientation branch from d60459d to 103b4c7 Compare July 15, 2019 16:56
@timhoffm
Copy link
Member Author

This rebase was not fun. 😢 We should come up with a plan against the pile-up of PRs. 🤷‍♂️

@jklymak
Copy link
Member
jklymak commented Jul 15, 2019

Well, there are a larger number of "style" and "simplification" PRs, which all have a burden on both reviewing and in getting other PRs through.

@timhoffm timhoffm force-pushed the inset-orientation branch from 103b4c7 to def2f8d Compare July 15, 2019 17:52
@dstansby
Copy link
Member

I wonder if it's time to introduce some more useful PR labels; maybe

  • Bug fix
  • New feature (could rename Wishlist to this)
  • Re-factoring

with the intention of making it easy to filter for bug fixes or new features if one wants to only spend time reviewing them.

@timhoffm timhoffm force-pushed the inset-orientation branch from def2f8d to 6eef5e1 Compare July 15, 2019 19:51
@anntzer anntzer merged commit 2bc6721 into matplotlib:master Jul 16, 2019
@timhoffm timhoffm deleted the inset-orientation branch July 16, 2019 20:49
@timhoffm
Copy link
Member Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.

indicate_inset rectangles is sensitive to axis-flipping
5 participants
@timhoffm @clbarnes @jklymak @dstansby @anntzer
0