8000 Update IPython's doc link in Image tutorial by bingyao · Pull Request #14666 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Update IPython's doc link in Image tutorial #14666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tacaswell merged 2 commits into from
Jul 2, 2019
Merged

Update IPython's doc link in Image tutorial #14666

tacaswell merged 2 commits into from
Jul 2, 2019

Conversation

@bingyao
Copy link
Contributor
@bingyao bingyao commented Jul 1, 2019 •
edited
Loading

PR Summary

This PR makes two changes:

  • Commit 20c3061: Current Image tutorials has an old link for IPython's documentation on GUI event loops, this PR updates it to the latest one.
  • Commit 5f8643c: Change outdated references from IPython Notebook to Jupyter Notebook.

@bingyao
Copy link
Contributor Author
bingyao commented Jul 1, 2019

Also, in Image tutorial, it still refers the Notebook environment as IPython Notebook, I think it would be better to change it to Jupyter Notebook.

Should I make these changes here? or with a new branch and PR?

@timhoffm
Copy link
Member
timhoffm commented Jul 1, 2019

Yes, please change to Jupyter Notebook. You can do the change here.

@bingyao bingyao force-pushed the docs_update_link branch from 160e084 to 5f8643c Compare July 2, 2019 01:19
@tacaswell tacaswell added this to the v3.2.0 milestone Jul 2, 2019
@tacaswell tacaswell merged commit 73d7119 into matplotlib:master Jul 2, 2019
@tacaswell
Copy link
Member
tacaswell commented Jul 2, 2019

Thanks @bingyao !

@bingyao bingyao deleted the docs_update_link branch July 8, 2019 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bingyao @timhoffm @tacaswell
0