8000 Simplify implementation of set_{x,y}bound. by anntzer · Pull Request #14609 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Simplify implementation of set_{x,y}bound. #14609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2019
Merged

Simplify implementation of set_{x,y}bound. #14609

merged 1 commit into from
Sep 15, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 24, 2019

... and don't refer to a private attribute in the docstring.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

QuLogic
QuLogic reviewed Jun 25, 2019
View reviewed changes
Copy link
Member
@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you didn't update the docstring for z.

@anntzer
Simplify implementation of set_{x,y}bound.
a60ac1a 
... and don't refer to a private attribute in the docstring.
@anntzer
Copy link
Contributor Author
anntzer commented Jun 25, 2019

oops, now edited the z docstring as well.

@tacaswell tacaswell added this to the v3.3.0 milestone Aug 24, 2019
@timhoffm timhoffm merged commit 86778dc into matplotlib:master Sep 15, 2019
@anntzer anntzer deleted the xybound branch September 15, 2019 18:59
@tacaswell tacaswell mentioned this pull request Oct 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @tacaswell
0