8000 In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching. by anntzer · Pull Request #14592 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching. #14592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching. #14592

merged 1 commit into from
Feb 25, 2020

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 20, 2019

_set_scale checks whether the parent scale changed before modifying the
secondary scale. set_functions should do the same. See added test for
previously failing case.

(Basically a followup to #14447.)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer force-pushed the secondaryformatter branch from 650323a to 0e1f13b Compare June 20, 2019 22:36
@tacaswell tacaswell added this to the v3.3.0 milestone Aug 24, 2019
@anntzer
In SecondaryAxis.set_functions, reuse _set_scale's parent scale caching.
c7f6506 
_set_scale checks whether the parent scale changed before modifying the
secondary scale.  set_functions should do the same.  See added test for
previously failing case.
@anntzer anntzer force-pushed the secondaryformatter branch from 0e1f13b to c7f6506 Compare February 5, 2020 15:24
@jklymak jklymak mentioned this pull request Feb 25, 2020
Closed
ImportanceOfBeingErnest
ImportanceOfBeingErnest approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member
@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm positive about this. Also fixes #15621

@jklymak jklymak merged commit ad877a0 into matplotlib:master Feb 25, 2020
@anntzer anntzer deleted the secondaryformatter branch February 25, 2020 19:54
@Wlodarski Wlodarski mentioned this pull request Mar 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@ImportanceOfBeingErnest ImportanceOfBeingErnest ImportanceOfBeingErnest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jklymak @ImportanceOfBeingErnest @tacaswell
0