Move setting of AA_EnableHighDpiScaling before creating QApplication. #14566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jun 18, 2019
| QtWidgets.QApplication.setAttribute( | ||
| QtCore.Qt.AA_EnableHighDpiScaling) | ||
| except AttributeError: | ||
| pass |
There was a problem hiding this comment.
Would add a comment # QtCore.Qt.AA_EnableHighDpiScaling only available on Qt >= 5.6 to clarify why we expect an AttributeError.
This is required by the docs (https://doc.qt.io/qt-5/qt.html#ApplicationAttribute-enum) and Qt 5.12.4 has started emitting a warning otherwise ("Attribute Qt::AA_EnableHighDpiScaling must be set before QCoreApplication is created.")
1e4c746 to
f008360
Compare
timhoffm
approved these changes
Jun 18, 2019
dstansby
reviewed
Jun 18, 2019
| @@ -118,6 +118,11 @@ def _create_qApp(): | |||
| if display is None or not re.search(r':\d', display): | |||
| raise RuntimeError('Invalid DISPLAY variable') | |||
|
|
|||
| try: | |||
| QtWidgets.QApplication.setAttribute( | |||
| QtCore.Qt.AA_EnableHighDpiScaling) | |||
There was a problem hiding this comment.
This was inside a if is_pyqt5() block below; does running this still work fine on Qt4?
There was a problem hiding this comment.
that'll be caught by the AttributeError too.
dstansby
approved these changes
Jun 18, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 18, 2019
… before creating QApplication.
timhoffm
added a commit
that referenced
this pull request
Jun 18, 2019
…566-on-v3.1.x Backport PR #14566 on branch v3.1.x (Move setting of AA_EnableHighDpiScaling before creating QApplication.)
|
We may need to put a similar change into ipython as they frequently create the QApplication instance we use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required by the docs
(https://doc.qt.io/qt-5/qt.html#ApplicationAttribute-enum)
and Qt 5.12.4 has started emitting a warning otherwise
("Attribute Qt::AA_EnableHighDpiScaling must be set before
QCoreApplication is created.")
PR Summary
PR Checklist