8000 Link to matplotlibrc of used version by timhoffm · Pull Request #14548 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Link to matplotlibrc of used version #14548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

timhoffm
Copy link
Member

PR Summary

When suggesting to update matplotlibrc, link to the relased version of the current code, not master.

Follow up to prevent confusion of #14547.

@tacaswell
Copy link
Member

Is the template someplace in the build docs? It might make more sense to link there rather than github?

I can see why either way would be better, 👍 in either case.

@tacaswell tacaswell added this to the v3.1.2 milestone Jun 13, 2019
@timhoffm
Copy link
Member Author

You have https://matplotlib.org/devdocs/tutorials/introductory/customizing.html#a-sample-matplotlibrc-file, but I don't think you have the file itself in the built docs.

@tacaswell
Copy link
Member

Maybe use https://raw.githubusercontent.com/matplotlib/matplotlib/v3.1.0/matplotlibrc.template instead so it is something you can wget? If it is going to go to a page you have to copy-paste anyway, I think the docs are marginally better.

In any case, this is an improvement, feel free to ignore my 🚲 🏠 comments.

@timhoffm
Copy link
Member Author

@tacaswell Thanks for your comment. I take the liberty and not follow it. It is not obvious that https://raw.githubusercontent.com/matplotlib/matplotlib/v3.1.0/matplotlibrc.template is the actual file. So I assume that most people will put it in a browser anyway to check. And then, your link is also just one click away.

Additionally, with the github link you can access the history and lookup what was changed recently.

@anntzer anntzer merged commit 29ca11d into matplotlib:master Jun 14, 2019
@timhoffm timhoffm deleted the link-matplotlibrc branch June 16, 2019 09:44
@QuLogic
Copy link
Member
QuLogic commented Jul 17, 2019

@meeseeksdev backport to v3.1.x

@lumberbot-app
Copy link
lumberbot-app bot commented Jul 17, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 29ca11d06ac2cb6c377d76b590c96515f644524a
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #14548: Link to matplotlibrc of used version'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-14548-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #14548 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@QuLogic
Copy link
Member
QuLogic commented Jul 17, 2019

Backport in #14828.

tacaswell added a commit that referenced this pull request Jul 17, 2019
…3.1.x

Backport PR #14548: Link to matplotlibrc of used version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0