-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Link to matplotlibrc of used version #14548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is the template someplace in the build docs? It might make more sense to link there rather than github? I can see why either way would be better, 👍 in either case. |
You have https://matplotlib.org/devdocs/tutorials/introductory/customizing.html#a-sample-matplotlibrc-file, but I don't think you have the file itself in the built docs. |
Maybe use https://raw.githubusercontent.com/matplotlib/matplotlib/v3.1.0/matplotlibrc.template instead so it is something you can wget? If it is going to go to a page you have to copy-paste anyway, I think the docs are marginally better. In any case, this is an improvement, feel free to ignore my 🚲 🏠 comments. |
@tacaswell Thanks for your comment. I take the liberty and not follow it. It is not obvious that https://raw.githubusercontent.com/matplotlib/matplotlib/v3.1.0/matplotlibrc.template is the actual file. So I assume that most people will put it in a browser anyway to check. And then, your link is also just one click away. Additionally, with the github link you can access the history and lookup what was changed recently. |
@meeseeksdev backport to v3.1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
Backport in #14828. |
…3.1.x Backport PR #14548: Link to matplotlibrc of used version
PR Summary
When suggesting to update matplotlibrc, link to the relased version of the current code, not master.
Follow up to prevent confusion of #14547.