Remove the "Developing a new backend" section from contributing guide. #14543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That section basically duplicates the "what is a backend" section in the usage guide, but does so less well, and doesn't provide relevant information for actually *developing* a new backend.
timhoffm
approved these changes
Jun 13, 2019
There was a problem hiding this comment.
I agree that this section should be removed here. Other than what I would expect from a section in Contributing -> Developing a new backend this does not tell anything about how to develop a backend. This just tells how to use a non-builtlin backend. Furthermore, I don't think there are many (any except @anntzer?) people developing new backends, so we don't need such a section.
That said, I still think that the usage guilde is not quite clear about the backend. I mixes "how to set a backend" with "how to set a non-builtin backend" in an ambiguous way. Will do a separate PR on this.
|
you'd be surprised by how many people develop new backends that suit their
purposes. Consider ipython/jupyter, and pycharm, for example, as two other
backends that are widely used, even if people don't realize they are using
them.
…On Thu, Jun 13, 2019 at 4:43 PM Tim Hoffmann ***@***.***> wrote:
***@***.**** approved this pull request.
I agree that this section should be removed here. Other than what I would
expect from a section in Contributing -> Developing a new backend this
does not tell anything about how to develop a backend. This just tells how
to *use* a non-builtlin backend. Furthermore, I don't think there are
many (any except @anntzer <https://github.com/anntzer>?) people
developing new backends, so we don't need such a section.
That said, I still think that the usage guilde
<https://matplotlib.org/devdocs/tutorials/introductory/usage.html#backends>
is not quite clear about the backend. I mixes "how to set a backend" with
"how to set a non-builtin backend" in an ambiguous way. Will do a separate
PR on this.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#14543?email_source=notifications&email_token=AACHF6HDMKEFNFZCK2XZ42LP2KWQ5A5CNFSM4HX3YJW2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3QIEMA#pullrequestreview-249594416>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACHF6EHG3DZSIJX2P36PTLP2KWQ5ANCNFSM4HX3YJWQ>
.
|
|
I would guess both of these backends have probably existed for years, so don't really qualify as new... |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a si
2EF7
ngle commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That section basically duplicates the "what is a backend" section in the usage guide (https://matplotlib.org/devdocs/tutorials/introductory/usage.html#backends), but does so less well, and doesn't provide relevant information for actually developing a new backend.
PR Summary
PR Checklist