Improve custom figure example #14499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d8336e to
b1c76db
Compare
anntzer
reviewed
Jun 12, 2019
|
|
||
| if watermark is not None: | ||
| bbox = dict(boxstyle='square', lw=3, ec='gray', | ||
| fc=(0.9, 0.9, .9, .5), alpha=0.5) |
There was a problem hiding this comment.
I don't really care whether you use 0.9 or .9, but at least be consistent :) (and same with 0.5 here and below)
anntzer
reviewed
Jun 12, 2019
| @@ -1,27 +1,55 @@ | |||
| """ | |||
| =================== | |||
| Custom Figure Class | |||
| Custom Figure class | |||
There was a problem hiding this comment.
subclass? sure, in theory, it can be any class that's "figure-like", but in practice that'll be a Figure subclass.
There was a problem hiding this comment.
Maybe "Customizing Figure by subclassing" or just "Subclassing Figure"?
There was a problem hiding this comment.
Any preference? The second one is shorter the first one is more precise.
There was a problem hiding this comment.
"Custom Figure subclasses"?
anntzer
reviewed
Jun 12, 2019
| =================== | ||
|
|
||
| You can pass a custom Figure constructor to figure if you want to derive from | ||
| the default Figure. This simple example creates a figure with a figure title. | ||
| You can pass a custom Figure class to `.pyplot.figure` if you want to change |
b1c76db to
8ee355c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Just wanted to do a bit style cleanup, but ended up rewriting the whole example. 😄
I didn't like about the original example that it's not a reasonable application. Setting a fixed position
Textas title is not quite suitable because it is not contained in any layout. If anything, one should useFigure.suptitle. But defining a subclass for this would be overkill. Usingfig.suptitle('my title')explicitly is easier thanplt.figure(FigureClass=MyFigure, title='my title').