Fix uses of PyObject_IsTrue. #14491
Merged
Fix uses of PyObject_IsTrue. #14491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyObject_IsTrue can return -1 if an exception occurred when trying to
convert a Python object to a bool (a typical case is for numpy arrays,
which cannot be converted to bools). Failure to handle this correctly
results e.g. in
```
l, = plt.plot([1, 2]); l.get_path().should_simplify = np.array([1, 2])
```
```
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/usr/lib/python3.7/site-packages/matplotlib/backends/backend_qt5.py", line 501, in _draw_idle
<elided>
File "/usr/lib/python3.7/site-packages/matplotlib/backends/backend_agg.py", line 146, in draw_path
self._renderer.draw_path(gc, path, transform, rgbFace)
SystemError: PyEval_EvalFrameEx returned a result with an error set
```
whereas after this PR, the ValueError gets correctly propagated out.
No tests, because one really needs to go out of their way to trigger the
faulty cases anyways...
timhoffm
approved these changes
Jun 8, 2019
|
This should probably get backported? |
|
Up to you :) |
WeatherGod
approved these changes
Jun 8, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 8, 2019
timhoffm
added a commit
that referenced
this pull request
Jun 8, 2019
…491-on-v3.1.x Backport PR #14491 on branch v3.1.x (Fix uses of PyObject_IsTrue.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cann
2A92
ot be applied right now. Please check back later.
PyObject_IsTrue can return -1 if an exception occurred when trying to
convert a Python object to a bool (a typical case is for numpy arrays,
which cannot be converted to bools). Failure to handle this correctly
results e.g. in
whereas after this PR, the ValueError gets correctly propagated out.
No tests, because one really needs to go out of their way to trigger the
faulty cases anyways...
PR Summary
PR Checklist