Deprecate checkdep_usetex. #14455
Closed
Deprecate checkdep_usetex. #14455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See changelog for rationale. Note that checkdep_usetex was *only* used to create a test decorator. This also goes well with the deprecation of all other checkdep_foo helpers in the matplotlib toplevel module. Instead, just directly write the proper test decorator. Use unittest.skipIf instead of pytest.skipif as pytest handles the unittest decorator just as well, and this makes the decorator work if someone *really* wants to use it in a non-pytest test suite.
b3103dc to
21ac34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See changelog for rationale. Note that checkdep_usetex was only
used to create a test decorator (and even then, the surrounding
catch_warnings was pointless after checkdep_usetex switched to using
logging -- one would really need to capture the logs instead).
This also goes well with the deprecation of all other checkdep_foo
helpers in the matplotlib toplevel module.
Instead, just directly write the proper test decorator. Use
unittest.skipIf instead of pytest.skipif as pytest handles the unittest
decorator just as well, and this makes the decorator work if someone
really wants to use it in a non-pytest test suite.
--
edit: oops, but that doesn't work with pytest.param. Will investigate more...
PR Summary
PR Checklist