8000 Use aspect=1, not aspect=True. by anntzer · Pull Request #14410 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Use aspect=1, not aspect=True. #14410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 2, 2019
Merged

Use aspect=1, not aspect=True. #14410

merged 1 commit into from
Jun 2, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jun 1, 2019

aspect=True seems like an obfuscated way to spell aspect=1 ("equal
aspect").

(Note that this should not be confused with uses of aspect=True in
AxesGrid, which is different and actually takes a bool as argument...)

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Use aspect=1, not aspect=True.
31ae50f 
aspect=True seems like an obfuscated way to spell aspect=1 ("equal
aspect").

(Note that this should not be confused with uses of `aspect=True` in
AxesGrid, which is different and actually takes a bool as argument...)
jkseppan
jkseppan approved these changes Jun 2, 2019
View reviewed changes
Copy link
Member
@jkseppan jkseppan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also use aspect='equal' but 1 is definitely clearer than True

@dstansby dstansby merged commit 39192d5 into matplotlib:master Jun 2, 2019
@dstansby dstansby added this to the v3.2.0 milestone Jun 2, 2019
@anntzer anntzer deleted the aspect1 branch June 2, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkseppan jkseppan jkseppan approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @jkseppan @dstansby
0