8000 Revert "Preserve whitespace in svg output." by anntzer · Pull Request #14403 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Revert "Preserve whitespace in svg output." #14403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2019
Merged

Revert "Preserve whitespace in svg output." #14403

merged 1 commit into from
Jun 1, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 31, 2019

This reverts commit 5c54324.
Closes #14283.

Release critical unless someone knows enough CSS to find a solution that doesn't rebreak the first half of #13200 (the second half being still broken).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. backend: svg labels May 31, 2019
@anntzer anntzer added this to the v3.1.1 milestone May 31, 2019
@tacaswell
Copy link
Member

Thank you @anntzer

@dstansby dstansby merged commit 9fdafae into matplotlib:master Jun 1, 2019
@lumberbot-app
Copy link
lumberbot-app bot commented Jun 1, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 9fdafae6b844f73cebde2f90cc99b6469a0502c7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #14403: Revert "Preserve whitespace in svg output."'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-14403-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #14403 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the unsvg branch June 1, 2019 10:22
@tacaswell tacaswell mentioned this pull request Jun 3, 2019
Merged
5 tasks
dstansby added a commit to dstansby/matplotlib that referenced this pull request Jun 7, 2019
@dstansby
Merge pull request matplotlib#14403 from anntzer/unsvg
65ba07d 
Revert "Preserve whitespace in svg output."
@dstansby dstansby mentioned this pull request Jun 7, 2019
Merged
dstansby added a commit that referenced this pull request Jun 7, 2019
@dstansby
Merge pull request #14486 from dstansby/14403-backport
2bd61a6 
Backport #14403 on v3.1.
@lgeiger lgeiger mentioned this pull request Jul 2, 2019
Merged
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Jul 11, 2019
Closed
@anntzer anntzer mentioned this pull request May 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

Assignees
No one assigned
Labels
backend: svg Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

RendererSVG CSS 'white-space' property conflicts with default HTML CSS
3 participants
@anntzer @tacaswell @dstansby
0