10000 Fix to_rgba_array() for empty input by timhoffm · Pull Request #14400 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Fix to_rgba_array() for empty input #14400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2019
Merged

Fix to_rgba_array() for empty input #14400

merged 1 commit into from
Jun 1, 2019

Conversation

timhoffm
Copy link
Member

PR Summary

This fixes a regression introduced in #14259.

to_rgba_array([]) must return a (0, 4) shape array, not a (0,) shape array.

@timhoffm timhoffm added this to the v3.2.0 milestone May 31, 2019
anntzer
anntzer approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor
@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

postci

@dstansby dstansby merged commit 152b6ff into matplotlib:master Jun 1, 2019
@timhoffm timhoffm deleted the fix-to-rgba-array-empty branch June 2, 2019 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
topic: color/color & colormaps
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@timhoffm @anntzer @dstansby
0