8000 Remove the ``package_data.dlls`` setup.cfg entry. by anntzer · Pull Request #14383 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove the package_data.dlls setup.cfg entry. #14383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2019
Merged

Remove the package_data.dlls setup.cfg entry. #14383

merged 1 commit into from
Jun 9, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 30, 2019

See changelog for details.

DLLs won't end up in the source tree unless one explicitly copies them
there, so let's assume that whoever does this knows what they're doing.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove the package_data.dlls setup.cfg entry.
f444674 
See changelog for details.

DLLs won't end up in the source tree unless one explicitly copies them
there, so let's assume that whoever does this knows what they're doing.
@tacaswell tacaswell added this to the v3.2.0 milestone May 31, 2019
tacaswell
tacaswell approved these changes Jun 8, 2019
View reviewed changes
Copy link
Member
@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on @cgohlke not using this.

@cgohlke
Copy link
Contributor
cgohlke commented Jun 9, 2019

LGTM

@timhoffm timhoffm merged commit 29265dc into matplotlib:master Jun 9, 2019
@anntzer anntzer deleted the package_dlls branch June 9, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Build OS: Microsoft
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @cgohlke @tacaswell @timhoffm
0