8000 Remove unnecessary uses of unittest.mock. by anntzer · Pull Request #14379 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary uses of unittest.mock. #14379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2019
Merged

Remove unnecessary uses of unittest.mock. #14379

merged 1 commit into from
Jun 8, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented May 30, 2019

Quite often it's just fine to create a throwaway class instead, which
actually makes the test tighter (mocks will automagically create missing
attributes, so using a throwaway class asserts that no such attribute is
accessed).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove unnecessary uses of unittest.mock.
ddfa787 
Quite often it's just fine to create a throwaway class instead, which
actually makes the test tighter (mocks will automagically create missing
attributes, so using a throwaway class asserts that no such attribute is
accessed).
@timhoffm timhoffm merged commit dfaa410 into matplotlib:master Jun 8, 2019
@QuLogic QuLogic added this to the v3.2.0 milestone Jun 8, 2019
@anntzer anntzer deleted the unmock branch June 8, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkseppan jkseppan jkseppan approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @jkseppan @timhoffm @QuLogic
0