8000 acquiring and releasing keypresslock when textbox is being activated by fariza · Pull Request #14343 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

acquiring and releasing keypresslock when textbox is being activated #14343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 30, 2019
Merged

acquiring and releasing keypresslock when textbox is being activated #14343

merged 3 commits into from
May 30, 2019
+19 −10

Conversation

fariza
Copy link
Member
@fariza fariza commented May 27, 2019

Making TextBox widget compatible with ToolManager

As reported #7571 textbox widget doesn't exclude the keypress triggers when using toolmanager.
This PR uses the toolmanager.keypresslock to bypass triggering the tools instead of the current solution of removing the content of rcParams

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@fariza fariza mentioned this pull request May 27, 2019
Closed
anntzer
anntzer reviewed May 27, 2019
View reviewed changes
timhoffm
timhoffm approved these changes May 30, 2019
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anntzer anntzer merged commit f67d556 into matplotlib:master May 30, 2019
@anntzer anntzer added this to the v3.2.0 milestone May 30, 2019
@tacaswell
Copy link
Member

Welcome back @fariza !

@derrickturk derrickturk mentioned this pull request Feb 27, 2025
Open
@QuLogic QuLogic changed the title acquiring and releaseing keypresslock when textbox is being activated acquiring and releasing keypresslock when textbox is being activated Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer left review comments

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: widgets/UI
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@fariza @tacaswell @anntzer @timhoffm
0