Add explanation of animation.embed_limit to matplotlibrc.template #14335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
May 26, 2019
| @@ -615,4 +615,5 @@ | |||
| ## On Windows use the full path since convert | |||
| ## is also the name of a system tool. | |||
| #animation.convert_args: ## Additional arguments to pass to convert | |||
| #animation.embed_limit : 20.0 | |||
| #animation.embed_limit : 20.0 ## Limit, in MB, of size of base64 encoded | |||
There was a problem hiding this comment.
The limit is in MiB, not MB, and everything really should be fixed to say that.
There was a problem hiding this comment.
While technically, you are right, I tend not to change that. MB is still more well known and understandable to non computer science affine users than MiB.
There was a problem hiding this comment.
This is a tough one. I have sympathy for the idea of helping maintain an international standard. On the other hand, I had to look up if MiB was different than MB.
dstansby
approved these changes
May 27, 2019
NelleV
approved these changes
Jun 1, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Jun 1, 2019
…t to matplotlibrc.template
dstansby
added a commit
that referenced
this pull request
Jun 1, 2019
…335-on-v3.1.x Backport PR #14335 on branch v3.1.x (Add explanation of animation.embed_limit to matplotlibrc.template)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion t
3149
o a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied comment from https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/rcsetup.py#L1466