Update to Bounding Box for Qt5 FigureCanvasATAgg.paintEvent() #14310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. That this only happens on OSX + pyside2 suggests that this is an upstream bug. Do we want to gate this based on that? I think this has the cost that we will no longer do partial redraws? The documentation was a bit unclear what coordinate system the rectangle on the event is in.... |
|
@tacaswell Yeah I took a look at that too and it wasn't clear what would be passed in for all situations. It might be possible to distinguish between a I'm not sure if this same behavior is true for PyQT5 or not. It might be. Should I go ahead and upgrade this to true PR? |
|
Closing this PR in favor of #14456. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR is intended to address #14160 by using dimensions of the renderer rather than the
QPaintEventrectangle passed to thepaintEventmethod. It seems the dimensions of this rectangle are dependent on the event type triggering thepaintEventcall (at least in OSX) when usingPySide2.