Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might happen to fix the scatter example, but I don't understand the logic of it--why should masked values in offsets be set to zero? I suspect the real problem with scatter and symlog is elsewhere. The points shouldn't be getting masked in the first place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, do you remember why you masked them in e959692 then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Originally, scatter handled masked values in any of its array inputs by forming a combined mask and then deleting the masked points from all of the arrays. The problem was that this led to a mismatch between the original input arrays and the plotted arrays, which caused trouble if the user subsequently tried to modify properties of the resulting collection. The solution was to let the collection handle the masked points instead of deleting them.
The problem that you are trying to fix here is only revealed, not caused, by this change--it is a problem related to an interaction between symlog and scatter, not a problem with the bad-value handling itself. It is related to the linear part of the symlog transformation. The mystery is why it shows up in scatter and not in plot. The points that are missing are those in the linear range; the default linthresh is 2.0, and the missing points are at 1 and 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation, going down the rabbit hole was driving me a bit nuts! I agree this isn't the right fix here, so will close the PR.