pep8ify a couple of variable names. #14273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
May 21, 2019
| @@ -892,7 +892,7 @@ def _print_figure( | |||
| metadata must be a dictionary. Currently, only the value for | |||
| the key 'Creator' is used. | |||
| """ | |||
| isEPSF = format == 'eps' | |||
| is_epsf = format == 'eps' | |||
There was a problem hiding this comment.
Whatever the 'f' stands for...
There was a problem hiding this comment.
looks like just an alternate extension for eps... https://en.wikipedia.org/wiki/Encapsulated_PostScript
There was a problem hiding this comment.
Would change to is_eps then. It‘s equal, more common, and the string we use for the format.
The deleted block in backend_pdf (`if (width > paperWidth or height > paperHeight) and isEPSF:`) can never be triggered as it's in the `else` clause of an `if isEPSF` just above. Looks like this came in in 946c5f2 (2009) and no one ever complained about the missing log, so I think it can just be deleted.
efiring
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deleted block in backend_pdf
(
if (width > paperWidth or height > paperHeight) and isEPSF:)can never be triggered as it's in the
elseclause of anif isEPSFjust above. Looks like this came in in 946c5f2 (2009) and no one ever
complained about the missing log, so I think it can just be deleted.
PR Summary
PR Checklist