Fix linear segmented colormap with one element #14241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anntzer
reviewed
May 18, 2019
lib/matplotlib/colors.py
Outdated
| @@ -665,6 +669,7 @@ def __init__(self, name, segmentdata, N=256, gamma=1.0): | |||
|
|
|||
| def _init(self): | |||
| self._lut = np.ones((self.N + 3, 4), float) | |||
| print(self._lut[:-3, 0].shape) | |||
9d5f49a to
9999fca
Compare
tacaswell
approved these changes
May 18, 2019
9999fca to
89823a5
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 18, 2019
timhoffm
added a commit
that referenced
this pull request
May 18, 2019
…241-on-v3.1.x Backport PR #14241 on branch v3.1.x (Fix linear segmented colormap with one element)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #14232.
Bug was introduced via #13097 where https://github.com/matplotlib/matplotlib/pull/13097/files#diff-1417350fe654c637d773bb4eac12b8f0 will make at least a 2-element list even for N=1.
The fix special-casese N=1 instead of reverting. I think it's cleaner that way. In particular also because the chosen value for N=1 is an arbitrary choice and we can make that obvious in the special-casing. The choice (color at x=1) is compatible with the former behavior.