8000 Replace 1-tuples by scalars where possible. by anntzer · Pull Request #13097 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Replace 1-tuples by scalars where possible. #13097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2019
Merged

Replace 1-tuples by scalars where possible. #13097

merged 1 commit into from
Jan 4, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Jan 4, 2019

(x,) is a bit unsightly when x would work as well...

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
< 8000 code> Replace 1-tuples by scalars where possible.
2527617 
`(x,)` is a bit unsightly when `x` would work as well...
timhoffm
timhoffm reviewed Jan 4, 2019
View reviewed changes
lib/matplotlib/colorbar.py
@@ -818,7 +818,7 @@ def _process_values(self, b=None):
if self._extend_upper():
b = b + [b[-1] + 1]
b = np.array(b)
v = np.zeros((len(b) - 1,), dtype=float)
v = np.zeros(len(b) - 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that reasonable? This creates an int array which is later cast to a float array.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does?

In [3]: np.zeros(5).dtype
Out[3]: dtype('float64')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, it doesn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timhoffm you're thinking of np.arange, which does change dtype depending on input.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Sorry for the noise.

@QuLogic QuLogic merged commit af8a720 into matplotlib:master Jan 4, 2019
@QuLogic QuLogic added this to the v3.1 milestone Jan 4, 2019
@anntzer anntzer deleted the tupleless branch January 4, 2019 20:42
This was referenced Jan 4, 2019
Merged
Closed
@tacaswell tacaswell mentioned this pull request May 18, 2019
Closed
@timhoffm timhoffm mentioned this pull request May 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

@timhoffm timhoffm timhoffm left review comments

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @jklymak @timhoffm
0