8000 backend_pdf: optional rgbFace arg in fillp replaces code in draw_markers. Closes #1410 by efiring · Pull Request #1416 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

backend_pdf: optional rgbFace arg in fillp replaces code in draw_markers. Closes #1410 #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2012
Merged

backend_pdf: optional rgbFace arg in fillp replaces code in draw_markers. Closes #1410 #1416

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
715cd8d
Fix transparent markers in PDF backend. Closes #1410
mdboom Oct 17, 2012
2313e90
Merge branch 'transparent_pdf_markers' of git://github.com/mdboom/mat…
efiring Oct 20, 2012
364a2a5
backend_pdf: optional rgbFace arg in fillp replaces code in draw_markers
efiring Oct 20, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/matplotlib/backends/backend_pdf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,7 +1556,10 @@ def draw_markers(self, gc, marker_path, marker_trans, path, trans, rgbFace=None)
return

self.check_gc(gc, rgbFace)
fillp = gc.fillp()
if rgbFace:
fillp = gc.fillp()
else:
fillp = None
strokep = gc.strokep()

output = self.file.output
Expand Down
Binary file added lib/matplotlib/tests/baseline_images/test_axes/transparent_markers.pdf
View file
Open in desktop
Binary file not shown.
Binary file added lib/matplotlib/tests/baseline_images/test_axes/transparent_markers.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
289 changes: 289 additions & 0 deletions lib/matplotlib/tests/baseline_images/test_axes/transparent_markers.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
9 changes: 9 additions & 0 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,15 @@ def test_hist_stacked_weighted():
ax = fig.add_subplot(111)
ax.hist( (d1, d2), weights=(w1,w2), histtype="stepfilled", stacked=True)

@image_comparison(baseline_images=['transparent_markers'], remove_text=True)
def test_transparent_markers():
np.random.seed(0)
data = np.random.random(50)

fig = plt.figure()
ax = fig.add_subplot(111)
ax.plot(data, 'D', mfc='none', markersize=100)

if __name__=='__main__':
import nose
nose.runmodule(argv=['-s','--with-doctest'], exit=False)
0