8000 Remove extra keyword from pytest.skip call. by QuLogic · Pull Request #14125 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Remove extra keyword from pytest.skip call. #14125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2019
Merged

Remove extra keyword from pytest.skip call. #14125

merged 1 commit into from
May 4, 2019

Conversation

QuLogic
Copy link
Member
@QuLogic QuLogic commented May 4, 2019

PR Summary

There is no reason keyword argument to the top-level pytest.skip function.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic
Remove extra keyword from pytest.skip call.
980bdbe 
There is no reason keyword argument to the top-level pytest.skip
function.
@QuLogic QuLogic added this to the v3.1.0 milestone May 4, 2019
@anntzer anntzer merged commit ddc1b23 into matplotlib:master May 4, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request May 4, 2019
@anntzer
Backport PR matplotlib#14125: Remove extra keyword from pytest.skip c…
8f00654 
…all.
@meeseeksmachine meeseeksmachine mentioned this pull request May 4, 2019
Merged
dstansby added a commit that referenced this pull request May 4, 2019
@dstansby
Merge pull request #14127 from meeseeksmachine/auto-backport-of-pr-14…
0e37862 
…125-on-v3.1.x

Backport PR #14125 on branch v3.1.x (Remove extra keyword from pytest.skip call.)
@QuLogic QuLogic deleted the pytest-skip-no-reason branch May 4, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
GUI: Qt topic: testing
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @timhoffm
0