8000 Add ridge_map to third party packages documentation by ColCarroll · Pull Request #14119 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Add ridge_map to third party packages documentation #14119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2019

Conversation

ColCarroll
Copy link
Contributor

PR Summary

This adds the ridge_map library (https://github.com/ColCarroll/ridge_map) to https://matplotlib.org/thirdpartypackages/index.html . I tried to make the example image as small as possible while still looking nice, but it still weighs 286kb. I can try some more tricks if that is too big!

Also no problem if this is a bad fit -- the other mapping libraries in here are very impressive and scientifically useful, while this is closer to an art project (which is important, but different!)

@QuLogic
Copy link
Member
QuLogic commented May 3, 2019

If you run optipng on it (no specific optimization level), you can save 40%. Also, cropping the outer white border might help a little (though perhaps not as much after optimization.)

@jklymak
Copy link
Member
jklymak commented May 3, 2019

Thats a pretty cool package. 👍 for putting it on the list.

@ColCarroll
Copy link
Contributor Author

Thanks for advice -- you were eerily correct on how much space it saved!

Output IDAT size = 173418 bytes (118839 bytes decrease)
Output file size = 173580 bytes (119260 bytes = 40.73% decrease)

@anntzer
Copy link
Contributor
anntzer commented May 3, 2019

you'll want to squash the first commit too, so that the old version doesn't stay in the git history.

@QuLogic
Copy link
Member
QuLogic commented May 3, 2019

We can squash merge it, and I might push an even smaller image too.

Can you make a release on PyPI too?

@QuLogic
Copy link
Member
QuLogic commented May 3, 2019

I shrunk it down some more by simply re-creating it closer to the size it would end up being on the page (364 ~= 400 px, anyway.)

@jklymak
Copy link
Member
jklymak commented May 3, 2019

That'll look pretty fuzzy on high-dpi displays.

@QuLogic
Copy link
Member
QuLogic commented May 3, 2019

We don't really have double-size for any other example plots.

@jklymak
Copy link
Member
jklymak commented May 3, 2019

We don't really have double-size for any other example plots.

True - it actually looks kind of bad that we don't do this. All our figures look pretty fuzzy in our docs.

@QuLogic
Copy link
Member
QuLogic commented May 3, 2019

Let's handle that in a separate PR then.

@QuLogic QuLogic added this to the v3.1.0 milestone May 3, 2019
@ColCarroll
Copy link
Contributor Author

Thanks for the prompt and friendly review! Added some CI and cut a release on PyPI last night: https://pypi.org/project/ridge-map/

@ColCarroll ColCarroll deleted the add-ridge-map branch May 4, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0