Simplify ribbon_box example. #14117
Merged
Simplify ribbon_box example. #14117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
May 4, 2019
examples/misc/demo_ribbon_box.py
Outdated
|
|
||
| fmt = ScalarFormatter(useOffset=False) | ||
| ax.xaxis.set_major_formatter(fmt) | ||
| heights = [7900, 8100, 7900, 6900, 9800] |
There was a problem hiding this comment.
Suggested change
| heights = [7900, 8100, 7900, 6900, 9800] | |
| heights = [7900, 8100, 7900, 6900, 9200] |
With 9800, the label slips out of the axes:
https://6974-7439715-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/gallery/misc/demo_ribbon_box.html
examples/misc/demo_ribbon_box.py
Outdated
|
|
||
| patch_gradient = BboxImage(ax.bbox, interpolation="bicubic", zorder=0.1) | ||
| gradient = np.zeros((2, 2, 4)) |
There was a problem hiding this comment.
Add a comment # background gradient.
Even though the example could use a bit more explanation, I'm not enforcing it as part of this PR, because this is an incremental improvement. However, adding this small comment at least helps to understand what this code segment is about.
There was a problem hiding this comment.
I just renamed the variable.
- Use AxesImage instead of the more obscure BboxImage. - Just hardcode the data instead of random-generating it and rounding it to hundreds when displaying. - Misc cleanups.
timhoffm
approved these changes
May 4, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 4, 2019
dstansby
added a commit
that referenced
this pull request
May 4, 2019
…117-on-v3.1.x Backport PR #14117 on branch v3.1.x (Simplify ribbon_box example.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to hundreds when displaying.
Inspired by #14057 (thanks @timhoffm)
PR Summary
PR Checklist