8000 Factor out retrieval of data relative to datapath by anntzer · Pull Request #14104 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]
Skip to content

Factor out retrieval of data relative to datapath #14104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2019
Merged

Factor out retrieval of data relative to datapath #14104

merged 1 commit into from
May 23, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 30, 2019

... into a cbook._get_data_path() helper.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

efiring
efiring approved these changes May 22, 2019
View reviewed changes
Copy link
Member
@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, and then let's merge it.

@anntzer
Copy link
Contributor Author
anntzer commented May 22, 2019

done

timhoffm
timhoffm approved these changes May 22, 2019
View reviewed changes
Copy link
Member
@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@anntzer
Factor out retrieval of data relative to datapath
65d77bf 
... into a cbook._get_data_path() helper.
@efiring efiring merged commit 9814fe8 into matplotlib:master May 23, 2019
@anntzer anntzer deleted the data_path branch May 23, 2019 05:04
@QuLogic QuLogic added this to the v3.2.0 milestone May 24, 2019
@tacaswell tacaswell mentioned this pull request Mar 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efiring efiring efiring approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @efiring @timhoffm @QuLogic
0