8000 Cleanup bar_stacked, bar_unit_demo examples. by anntzer · Pull Request #14089 · matplotlib/matplotlib · GitHub
[go: up one dir, main page]

Skip to content

Cleanup bar_stacked, bar_unit_demo examples. #14089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

anntzer
Copy link
Contributor
@anntzer anntzer commented Apr 29, 2019

Use label=... to define legend labels (note that in the case here,
plt.legend((p1[0], p2[0]), (..., ...)) is not even that nice as it
exposes the internals of the bar object, so using label=... is clearly
simpler).

Pep8ify variables.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Use label=... to define legend labels (note that in the case here,
`plt.legend((p1[0], p2[0]), (..., ...))` is not even that nice as it
exposes the internals of the bar object, so using `label=...` is clearly
simpler).

Pep8ify variables.
@anntzer anntzer changed the title Cleanup bar_stacked example. Cleanup bar_stacked, bar_unit_demo examples. Apr 29, 2019
@timhoffm timhoffm merged commit e59b93b into matplotlib:master Apr 29, 2019
@anntzer anntzer deleted the bar_stacked branch April 29, 2019 19:05
@QuLogic QuLogic added this to the v3.2.0 milestone Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0