Check axes identity in image.contains. #14052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, image.contains(event) will incorrectly return True for a
click in *another* axes, somewhere else, that happens to be at the same
x/ydata. Try e.g.
```
from pylab import *
axs = gcf().subplots(2)
im0 = axs[0].imshow([[0, 1], [2, 3]])
im1 = axs[1].imshow([[0, 1], [2, 3]])
gcf().canvas.mpl_connect(
"button_press_event",
lambda event: print(im0.contains(event), im1.contains(event)))
show()
```
timhoffm
approved these changes
Apr 26, 2019
tacaswell
approved these changes
Apr 26, 2019
jklymak
reviewed
Apr 26, 2019
|
It's a bit of a pain to write these tests (because of the machinery needed to properly generate mouseevents at the right location, see e.g. test_path.py::test_arrow_contains_point); I'd rather write proper machinery (e.g. lifting it from mplcursors' test suite :)) for that instead of duplicating it again and again, but that's not very high in my priority list... |
|
I dunno: xdisp, ydisp = ax.transData.transform_point([x, y])
event = MouseEvent('button_press_event', fig.canvas, xdisp, ydisp)doesn't seem that painful. |
|
wanna write the test? :) |
|
I am fine with this going in without a test, not sure it needs to go in for 3.1 though. |
dopplershift
approved these changes
Apr 29, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 29, 2019
dstansby
added a commit
that referenced
this pull request
Apr 29, 2019
…052-on-v3.1.x Backport PR #14052 on branch v3.1.x (Check axes identity in image.contains.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, image.contains(event) will incorrectly return True for a
click in another axes, somewhere else, that happens to be at the same
x/ydata. Try e.g.
Probably a test would be nice, sure.
PR Summary
PR Checklist