Deprecate get_home() #14010
Merged
Deprecate get_home() #14010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
font_manager.py has been using Path.home() without any checks for a while, so the lack of crash reports indicate that Path.home() returns without crashing in any system that uses Matplotlib, so get_home() and its error handling can just be replaced by Path.home().
timhoffm
approved these changes
Apr 23, 2019
WeatherGod
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued t
2AD8
o merge.
Suggestion cannot be applied right now. Please check back later.
font_manager.py has been using Path.home() without any checks for a
while, so the lack of crash reports indicate that Path.home() returns
without crashing in any system that uses Matplotlib, so get_home() and
its error handling can just be replaced by Path.home().
PR Summary
PR Checklist