Allow pandas DataFrames through norms #14002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks reasonable, but I'm a little worried about the motivation: How far down in the library hierarchy should we be aiming and claiming to support structures like DataFrames? |
|
Indeed, I made the same comment at #10909 (comment). |
|
I don't care much either way in this particular case. But if we jump the extra hoop with NB: If this is followed up, please rebase to fix the numpydoc-v0.9 related doc failure. |
|
I'm also happy either way, but if we're going to disallow it I think it should raise a sensible error message. |
efiring
approved these changes
Apr 23, 2019
anntzer
approved these changes
May 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10909, and allows
Normobjects to be called with Pandas DataFrames. I think the change still works fine with other types of array subclasses, will see if the tests pass. If they do I will add a pandas test.