Fix patch contains logic for patches that don't have any codes #13998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c0835f to
41788da
Compare
tacaswell
approved these changes
Apr 21, 2019
|
Thanks for tracking this down! In the future, if we break down-stream packages, I think the bug-reports should come to us first (or at least concurrently) as we should not be breaking down-stream packages! |
timhoffm
approved these changes
Apr 22, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 22, 2019
…at don't have any codes
jklymak
added a commit
that referenced
this pull request
Apr 22, 2019
…998-on-v3.1.x Backport PR #13998 on branch v3.1.x (Fix patch contains logic for patches that don't have any codes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10776 changed the logic inside
Patch.contains(), and in particular includes the lineIf this evaluates to
None, then the proceeding logic doesn't work and raises an error. This has broken scrolling/zooming plots made with custom projections in Astropy (astropy/astropy#8545). I presume this is because there is a customPatchsomewhere along the line who's path doesn't contain any codes.This fix just checks if
self.get_path().codes == None, and if it is applies the old logic that was used before #10776 - not sure if this is the long term fix, but in the short term it should be fine.