Remove many unused variables in tests. #13957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tacaswell
reviewed
Apr 15, 2019
lib/matplotlib/tests/test_axes.py
Outdated
| ax = plt.subplot(4, 1, 4) | ||
| plt.hist(data_big, 100, histtype='stepfilled', log=True, | ||
| orientation='horizontal') | ||
| fig, axs = plt.subplots(4) |
Member
There was a problem hiding this comment.
This puts an unused variable in?
tacaswell
reviewed
Apr 15, 2019
|
|
||
| assert 'left' == ax.get_title(loc='left') | ||
| assert 'right' == ax.get_title(loc='right') | ||
| assert 'aardvark' == ax.get_title(loc='center') |
Member
There was a problem hiding this comment.
Probably should keep both versions of this.
Contributor
Author
There was a problem hiding this comment.
oops, that was removed by mistake. restored.
tacaswell
approved these changes
Apr 15, 2019
Member
There was a problem hiding this comment.
Minor concerns about touching the test suite in general, but looks ok.
I think some of those plt.figure calls were defensive from figure leaking between tests, but knowing when that isolation fails also seems useful.
26890ea to
2b3f5c5
Compare
timhoffm
reviewed
Apr 17, 2019
lib/matplotlib/tests/test_mlab.py
Outdated
| sides=self.sides, | ||
| mode='angle') | ||
| specm = np.mean(spec, axis=1) | ||
| np.mean(spec, axis=1) |
Member
There was a problem hiding this comment.
That's doing nothing. specs is not modified and the return value is not used.
lib/matplotlib/tests/test_mlab.py
Outdated
| sides=self.sides, | ||
| mode='phase') | ||
| specm = np.mean(spec, axis=1) | ||
| np.mean(spec, axis=1) |
lib/matplotlib/tests/test_scale.py
Outdated
| fig, ax = plt.subplots() | ||
| ax.set_yscale('log') | ||
| s = repr(ax.transData) | ||
| repr(ax.transData) |
Member
There was a problem hiding this comment.
Does nothing`? Or
Suggested change
| repr(ax.transData) | |
| repr(ax.transData) # smoke test that repr() succededs |
... as detected by enabling F841 in flake8. A lot of these are instantiations of figures which are not used because the test then uses the pyplot interface anyways; the figure doesn't need to be explicitly instantiated as tests always run with no preexisting figure (via an autouse fixture).
Contributor
Author
|
thanks, comments handled |
timhoffm
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as detected by enabling F841 in flake8.
A lot of these are instantiations of figures which are not used because
the test then uses the pyplot interface anyways; the figure doesn't need
to be explicitly instantiated as tests always run with no preexisting
figure (via an autouse fixture).
Split out from #13932 for reviewability.
PR Summary
PR Checklist